stream stdout IO immediately

Previously guard-mocha-node was buffering the output from mocha, resulting in no output shown to the user until mocha had completed. Now stdout at least streams out immediately.
neerolyte · Apr 21, 2013 · 8e1a5c0 · 8e1a5c0 · ashmoran · Aug 5, 2013
1 parent a231151
commit 8e1a5c0
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/guard/mocha_node/spec_state.rb b/lib/guard/mocha_node/spec_state.rb
@@ -20,9 +20,13 @@ def update(run_paths = [], options = {})
         @io = Runner.run(@run_paths, options)
         @stdout     = @io[STDOUT]
         @stderr     = @io[STDERR]
-        @exitstatus = @io[THREAD].value rescue ERROR_CODE
-        @stdout.lines { |line| print line if !line.strip.empty? }
+        # stream stdout immediately
+        until @stdout.eof?
+          line = @stdout.gets
+          print line if !line.strip.empty?
+        end
         @stderr.lines { |line| print line }
+        @exitstatus = @io[THREAD].value rescue ERROR_CODE
         close_io
         update_passed_and_fixed
         update_failing_paths

diff --git a/spec/lib/spec_state_spec.rb b/spec/lib/spec_state_spec.rb
@@ -21,7 +21,7 @@
   describe "#update" do
     let(:io) { [
                 double("stdin",  :close => true),
-                double("stdout", :close => true, :lines => []),
+                double("stdout", :close => true, :lines => [], :eof? => true),
                 double("stderr", :close => true, :lines => []),
                 double("thread", :value => 0)
                ] }