Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork Sync: Update from parent repository #142

Merged
merged 7 commits into from
Aug 23, 2023
Merged

Fork Sync: Update from parent repository #142

merged 7 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. [Feature] Expose term frequency in Painless script score context (#9081) 

    Add the following functions in Painless script score context:
* termfreq
* tf
* totaltermfreq
* sumtotaltermfreq

Each of these maps to a Lucene value source.

Signed-off-by: Louis Chu <[email protected]>
    @noCharger
    noCharger authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5d3633c View commit details
    Browse the repository at this point in the history

  2. [Remote Store] Fix tests when we restore index without any refresh (#… 

    …9480)

Signed-off-by: Sachin Kale <[email protected]>
    @sachinpkale
    sachinpkale authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    9272aa2 View commit details
    Browse the repository at this point in the history

  3. [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse (#… 

    …9410)

* [BUG] Reconstruct pit infos when deserialize GetAllPitNodesResponse

Signed-off-by: panguixin <[email protected]>

* add searializion test case

Signed-off-by: panguixin <[email protected]>

* run spotless

Signed-off-by: panguixin <[email protected]>

---------

Signed-off-by: panguixin <[email protected]>
    @bugmakerrrrrr
    bugmakerrrrrr authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    980bf3c View commit details
    Browse the repository at this point in the history

  4. Fix flaky test SegmentReplicationWithRemoteStorePressureIT.testAddRep… 

    …licaWhileWritesBlocked. (#9501)

This test fails on ensureGreen after adding a replica. This is run inside of the try with resources that blocks operations.  The block works by mocking transport calls to prevent segrep from completing until released.

Fixed by moving the ensureGreen until after releasing blockOperations. Also re
duced the doc count that is used while indexing down from max 200.  Writes wit
h the remote store version of this test take a much longer time to execute whe
n performed serially, and we don't need this many docs indexed to create needed checkpoints.

Signed-off-by: Marc Handalian <[email protected]>
    @mch2
    mch2 authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    d1678ba View commit details
    Browse the repository at this point in the history

  5. Run compatibility check based on PR base branch (#9374) 

    Signed-off-by: Sayali Gaikawad <[email protected]>
    @gaiksaya
    gaiksaya authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b8fe8b2 View commit details
    Browse the repository at this point in the history

  6. Add Michael Froh as a maintainer (#9463) 

    Signed-off-by: Andrew Ross <[email protected]>
    @andrross
    andrross authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    89ccda9 View commit details
    Browse the repository at this point in the history

  7. Fix range reads in respository-s3 (#9516) 

    The `readBlob(String, long, long)` method in the S3 repository has been
broken since the upgrade to AWS SDK v2. The cause is that the SDK v2
returns the content range length details in a string formatting per the
[RFC 9110][1] spec. For example:

```
bytes 0-100/200
```

However, the code was attempting to parse it as:

```
bytes=0-100
```

The fix here is to not parse this string at all and instead use
`GetObjectResponse#contentLength`.

Note that the incorrect format matches how a range is specified in a
_request_ per the [byte ranges][2] section of the RFC and that is likely
the source of the confusion. We lack any dedicated integration testing
of this method so the bug was not caught by any tests. Additionally, the
range read is only used by the searchable snapshot feature currently and
we have no automated integration testing with the different repository
implementations. One other complicating factor is that due to a fallback
path that returns `Long.MAX_VALUE - 1` when the range is failed to be
parsed, the bug will only manifest as a long overflow error when
requesting past the first block and therefore wasn't caught with very
simple manual testing.

[1]: https://www.rfc-editor.org/rfc/rfc9110.html#name-content-range
[2]: https://www.rfc-editor.org/rfc/rfc9110.html#name-byte-ranges

Signed-off-by: Andrew Ross <[email protected]>
    @andrross
    andrross authored Aug 23, 2023
    Configuration menu
    Copy the full SHA
    0c839c3 View commit details
    Browse the repository at this point in the history