Rewrite to add support for random-acces for Crypt4GHReader if support… #224
pontusAnnotations
7 errors and 2 warnings
|
Check code (1.20):
streaming/streaming_test.go#L848
unslice: could simplify buf[:] to buf (gocritic)
|
|
Check code (1.20):
streaming/in.go#L330
`if segmentPos != c.sourcePos` has complex nested blocks (complexity: 8) (nestif)
|
|
Check code (1.20):
streaming/in.go#L331
S1002: should omit comparison to bool constant, can be simplified to `seekable` (gosimple)
|
|
Check code (1.20):
streaming/in.go#L468
copylocks: GetHeader passes lock by value: github.com/neicnordic/crypt4gh/streaming.Crypt4GHReader contains sync.Mutex (govet)
|
|
Check code (1.20):
streaming/in.go#L172
return with no blank line before (nlreturn)
|
|
Check code (1.20):
streaming/in.go#L434
return with no blank line before (nlreturn)
|
|
Check code (1.20)
issues found
|
|
Check code (1.20)
Restore cache failed: Dependencies file is not found in /home/runner/work/crypt4gh/crypt4gh. Supported file pattern: go.sum
|
|
Check code (1.20):
streaming/in.go#L197
var-declaration: should drop = 0 from declaration of var i; it is the zero value (revive)
|