Last try with variables

neilenns · Dec 7, 2023 · 8ac0ce5 · 8ac0ce5
1 parent f4be749
commit 8ac0ce5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -39,10 +39,9 @@ jobs:
 
       - name: Downgrade NSIS
         shell: pwsh
-        run: .\Build\downgrade_nsis.ps1
-
-      - name: Verify makensis version
-        run: makensis.exe /VERSION
+        run: |
+          .\Build\downgrade_nsis.ps1
+          makensis.exe /VERSION
 
       - name: Restore NuGet packages
         working-directory: ${{env.GITHUB_WORKSPACE}}

diff --git a/Build/downgrade_nsis.ps1 b/Build/downgrade_nsis.ps1
@@ -3,7 +3,8 @@
 ##  Desc:  Install NSIS
 ################################################################################
 
-Invoke-WebRequest "https://netcologne.dl.sourceforge.net/project/nsis/NSIS%203/3.04/nsis-3.04-setup.exe" -OutFile "C:\WINDOWS\Temp\nsis-3.04-setup.exe"
+$NsisVersion = "3.04"
+Invoke-WebRequest "https://netcologne.dl.sourceforge.net/project/nsis/NSIS%203/${NsisVersion}/nsis-${NsisVersion}-setup.exe" -OutFile "C:\WINDOWS\Temp\nsis-${NsisVersion}-setup.exe"
 Invoke-Expression "& C:\WINDOWS\Temp\nsis-3.04-setup.exe /S"
 
 $NsisPath = "${env:ProgramFiles(x86)}\NSIS\"