Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybookを7系の最新安定版に更新 #256

Merged
merged 5 commits into from
Aug 13, 2023

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Aug 12, 2023

issueURL

#255

関連 URL

なし

Done の定義

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-slszbkrbvg.chromatic.com/

変更点概要

Storybookを 7.2.3 にアップグレード

最新安定版である 7.2.3 にアップグレード。

公式からは upgrade コマンドが用意されているが、Storybook側のTemplateも変わっていると思うので以下の手順で新規作成したプロジェクトを元にしてStorybookを入れ直した。

  1. 新規でNext.jsのプロジェクトを作成して npx storybook@latest init を実行。

  2. 以下で関連packageを削除

npm uninstall -D @storybook/addon-a11y @storybook/addon-actions @storybook/addon-essentials @storybook/addon-interactions @storybook/addon-links @storybook/builder-webpack5 @storybook/manager-webpack5 @storybook/react @storybook/testing-library storybook-addon-next
  1. 1で作成したプロジェクトを参考に必要なpackageを追加
npm install -D storybook @storybook/addon-essentials @storybook/addon-interactions @storybook/addon-links @storybook/addon-onboarding @storybook/blocks @storybook/nextjs @storybook/react @storybook/testing-library
  1. 設定ファイル、npm script等を新しいプロジェクトから移植

TypeScriptのバージョンを最新安定版の 5.1.6 にアップグレード

Storybookの6系が未対応のTypeScriptの5系に未対応だった為、4系を利用していたが今回の対応でアップグレード出来るようになったので対応。

不要なpackageを削除

webpack やPostCSSの不要なPluginが残っていたので削除した。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Aug 12, 2023
@vercel
Copy link

vercel bot commented Aug 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2023 8:27am

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b08b6bf) 74.22% compared to head (dbb3148) 74.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #256   +/-   ##
=======================================
  Coverage   74.22%   74.22%           
=======================================
  Files          48       48           
  Lines         454      454           
  Branches      113      113           
=======================================
  Hits          337      337           
  Misses        113      113           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review August 13, 2023 14:29
@keitakn keitakn merged commit a4c2099 into main Aug 13, 2023
5 checks passed
@keitakn keitakn deleted the feature/issue255/upgrade-storybook branch August 13, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant