Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

メンテナンスモードをVercel Edge Configから取得するように変更 #275

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jan 16, 2024

issueURL

#273

関連 URL

なし

このPRで対応すること / このPRで対応しないこと

Vercel Edge Configを利用したメンテナンスモードを実装する。

#273 のDoneの定義を満たす実装は全てこのPR内で対応する。

Storybook の URL もしくはスクリーンショット

なし

変更点概要

Vercel Edge Config を利用したメンテナンスモードを実装。

Vercel Edge Config は開発・ステージング用と本番用の2種類を用意した。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

不要になった環境変数 IS_IN_MAINTENANCE はこのPRがデプロイされたらVercel上から削除する。

@keitakn keitakn self-assigned this Jan 16, 2024
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 8:23am

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29a475a) 73.75% compared to head (6f91277) 73.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files          47       47           
  Lines         423      423           
  Branches      104      104           
=======================================
  Hits          312      312           
  Misses        107      107           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review January 19, 2024 08:26
@keitakn keitakn merged commit 299cb86 into main Jan 19, 2024
9 checks passed
@keitakn keitakn deleted the feature/issue273 branch January 19, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant