Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VercelのNode.js バージョンを20系に変更&packageの最新化 #277

Merged
merged 3 commits into from
Jan 20, 2024

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Jan 20, 2024

issueURL

#272

関連 URL

https://lgtm-cat-frontend-git-feature-issue272upgrade-bc9b4c-nekochans.vercel.app/

このPRで対応すること / このPRで対応しないこと

#272 のDoneの定義を満たす為の実装を全てこのPRで実装します。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-aszqtenjkq.chromatic.com/

変更点概要

タイトルの通り、ついでにNext.jsを含む依存packageも最新化した。動作確認を一通りしたが特に問題なさそう。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Jan 20, 2024
Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 3:26pm

Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bea8bf7) 73.75% compared to head (ac2c937) 73.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   73.75%   73.75%           
=======================================
  Files          47       47           
  Lines         423      423           
  Branches      104      104           
=======================================
  Hits          312      312           
  Misses        107      107           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review January 20, 2024 15:32
@keitakn keitakn merged commit 7b773a4 into main Jan 20, 2024
9 checks passed
@keitakn keitakn deleted the feature/issue272/upgrade-node-version branch January 20, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant