Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm packageを最新安定版に更新(デザインリニューアル前の最後のアップデート) #339

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Aug 15, 2024

issueURL

#335

関連 URL

https://lgtm-cat-frontend-git-feature-issue335update-n-e78442-nekochans.vercel.app/

このPRで対応すること / このPRで対応しないこと

npm packageを可能な限り最新安定版に更新。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-fvkpnpyafy.chromatic.com/

変更点概要

タイトルの通り。

nekochans/ai-cat-frontend#128 と同じく @typescript-eslint/eslint-plugin7.18.0 で止めている。

他の変更点概要は以下の通り。(Formatterの仕様が変わってコードのFormatを実施しているので差分が大きくなっている)

This pull request includes several updates to the ESLint configuration, dependency versions, and code cleanup by removing unnecessary ESLint disable comments. The most important changes are summarized below:

ESLint Configuration Updates:

  • Added eslint-plugin-storybook and eslint-plugin-vitest to the imports in eslint.config.mjs.
  • Removed plugin:vitest/recommended, plugin:storybook/recommended, and next/core-web-vitals from the default export in eslint.config.mjs.
  • Added storybook and vitest to the fixupPluginRules section in eslint.config.mjs.

Dependency Updates:

  • Updated various dependencies in package.json to their latest versions.
  • Updated PACKAGE_VERSION in public/mockServiceWorker.js to 2.3.5.

Code Cleanup:

  • Removed unnecessary ESLint disable comments across multiple files, including src/api/cognito/openIdConnect.ts, src/api/lgtmeow/lgtmImage.ts, src/app/api/lgtm-images/recently-created/route.ts, src/app/api/lgtm-images/route.ts, src/app/en/layout.tsx, src/app/layout.tsx, src/components/LgtmImages/LgtmImages.stories.tsx, src/components/Upload/UploadForm/UploadForm.tsx, src/components/Upload/UploadModal/UploadModal.tsx, src/features/imageData.ts, src/features/lgtmImage.ts, src/features/result.ts, src/features/url.ts, and src/features/validator.ts. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27]

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Aug 15, 2024
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 16, 2024 4:54pm

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 30.49%. Comparing base (008149b) to head (f26b706).
Report is 5 commits behind head on main.

Files Patch % Lines
eslint.config.mjs 0.00% 4 Missing ⚠️
src/instrumentation.ts 0.00% 2 Missing ⚠️
src/app/en/layout.tsx 0.00% 1 Missing ⚠️
src/app/layout.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
+ Coverage   21.06%   30.49%   +9.42%     
==========================================
  Files         250      262      +12     
  Lines       10179     6746    -3433     
  Branches      309      354      +45     
==========================================
- Hits         2144     2057      -87     
+ Misses       7848     4535    -3313     
+ Partials      187      154      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review August 16, 2024 16:57
@keitakn keitakn merged commit 8fc0b2c into main Aug 16, 2024
8 of 9 checks passed
@keitakn keitakn deleted the feature/issue335/update-npm-packages branch August 16, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant