Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

共通利用するButtonComponentを実装 #342

Merged

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Aug 18, 2024

issueURL

#303

関連 URL

StorybookでComponentを作成しただけなのでなし。

このPRで対応すること / このPRで対応しないこと

#303 の完了の定義を満たしている事。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-uqdzpgolqf.chromatic.com/?path=/story/app-components-iconbutton--with-github-icon

変更点概要

Button用の共通Componentを定義。

ただしアップロード用のボタンに関しては今回作成していない。

詳しくは以下を参照。

This pull request includes several changes focused on refactoring button components, updating dependencies, and extending the theme configuration. The most important changes include the removal of the Button component and its stories, the introduction of the IconButton and LinkButton components with their respective stories, and the extension of the Tailwind CSS configuration to include a new font family.

Changes to button components:

Dependency updates:

Theme configuration:

  • tailwind.config.ts: Extended the Tailwind CSS configuration to include the Inter font family.

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Aug 18, 2024
Copy link

vercel bot commented Aug 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 5:30pm

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 213 lines in your changes missing coverage. Please review.

Project coverage is 13.02%. Comparing base (65302bc) to head (4e46991).
Report is 12 commits behind head on release/epic36/design-renewal-2024.

Files Patch % Lines
src/app/_components/IconButton.stories.tsx 0.00% 78 Missing and 1 partial ⚠️
src/app/_components/IconButton.tsx 0.00% 78 Missing and 1 partial ⚠️
src/app/_components/LinkButton.stories.tsx 0.00% 27 Missing and 1 partial ⚠️
src/app/_components/LinkButton.tsx 0.00% 19 Missing and 1 partial ⚠️
tailwind.config.ts 0.00% 7 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           release/epic36/design-renewal-2024     #342      +/-   ##
======================================================================
- Coverage                               14.86%   13.02%   -1.84%     
======================================================================
  Files                                      47       49       +2     
  Lines                                    1164     1328     +164     
  Branches                                   71       73       +2     
======================================================================
  Hits                                      173      173              
- Misses                                    952     1114     +162     
- Partials                                   39       41       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn marked this pull request as ready for review August 23, 2024 17:37
@keitakn keitakn merged commit 5e35f8e into release/epic36/design-renewal-2024 Aug 23, 2024
7 of 9 checks passed
@keitakn keitakn deleted the feature/issue303/button-component branch August 23, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant