ESLintの設定を @antfu/eslint-config を使った形に変更 #353
Merged
+3,267
−2,059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/epic36/design-renewal-2024 #353 +/- ##
======================================================================
+ Coverage 33.78% 35.27% +1.48%
======================================================================
Files 75 75
Lines 1977 1874 -103
Branches 147 147
======================================================================
- Hits 668 661 -7
+ Misses 1260 1164 -96
Partials 49 49 ☔ View full report in Codecov by Sentry. |
src/utils/gtm.ts 36:13 error Use a `type` instead of an `interface` ts/consistent-type-definitions 42:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 51:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 60:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 69:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 78:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 87:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions 96:3 error Definition for rule '@typescript-eslint/strict-boolean-expressions' was not found @typescript-eslint/strict-boolean-expressions
src/utils/assertNever.ts 1:1 error Definition for rule '@typescript-eslint/no-unused-vars' was not found @typescript-eslint/no-unused-vars 2:29 error 'value' is defined but never used. Allowed unused args must match /^_/u unused-imports/no-unused-vars
/lgtm-cat-frontend/src/app/_components/Header.test.tsx 31:51 warning Use shorthand boolean attribute 'isLoggedIn' react/prefer-shorthand-boolean 42:51 warning Use shorthand boolean attribute 'isLoggedIn' react/prefer-shorthand-boolean /lgtm-cat-frontend/src/app/_components/HeaderLogo.tsx 21:41 warning Use shorthand boolean attribute 'aria-hidden' react/prefer-shorthand-boolean /lgtm-cat-frontend/src/app/_components/LoginButton.tsx 14:7 warning Use shorthand boolean attribute 'showGithubIcon' react/prefer-shorthand-boolean
keitakn
commented
Oct 10, 2024
| @@ -27,7 +27,8 @@ test('show isLoggedIn false language is en', () => { | |||
| expect(screen.getByRole('link', { name: 'Login' })).toBeTruthy(); | |||
| }); | |||
|
|
|||
| test('show isLoggedIn true language is ja', () => { | |||
| it('show isLoggedIn true language is ja', () => { | |||
| // eslint-disable-next-line react/prefer-shorthand-boolean | |||
There was a problem hiding this comment.
省略形で isLoggedIn と書くようにESLintが要求してきていますが、この書き方にするとIDE上で警告が出るのでここはインラインコメントで対象ルールを無効にしています
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issueURL
#347
関連 URL
なし
このPRで対応すること / このPRで対応しないこと
ESLintの設定を
@antfu/eslint-configを使った形に変更します。Storybook の URL もしくはスクリーンショット
UI変更はないのでなし。
変更点概要
@antfu/eslint-configを使ってESLintの設定を構築するように変更。prettierについては利用しなくなったので依存packageから削除している。詳しい解説は nekochans/ai-cat-frontend#132 のインラインコメントを参照。
レビュアーに重点的にチェックして欲しい点
特になし
補足情報
インラインコメントを参照。