Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeaderComponentのマージンの調整 #355

Conversation

keitakn
Copy link
Member

@keitakn keitakn commented Oct 11, 2024

issueURL

#354

関連 URL

全てのURLで利用されます。

このPRで対応すること / このPRで対応しないこと

HeaderComponentのマージンの調整を行いもう少し広めの幅でも利用出来るようにします。

Storybook の URL もしくはスクリーンショット

https://622b6c5dc31e9e003a111eb5-uewsxqkmcw.chromatic.com/?path=/story/app-components-header--header-in-japanese

変更点概要

HeaderComponentのマージンの調整して少し狭めのデスクトップ幅でも利用出来るようにしました。

とは言えスマホ対応が必要なのでそれに関しては別途対応します。

レビュアーに重点的にチェックして欲しい点

特になし

補足情報

特になし

@keitakn keitakn self-assigned this Oct 11, 2024
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lgtm-cat-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:22am

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.27%. Comparing base (3ce8e6f) to head (75d3c38).
Report is 3 commits behind head on release/epic36/design-renewal-2024.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           release/epic36/design-renewal-2024     #355   +/-   ##
===================================================================
  Coverage                               35.27%   35.27%           
===================================================================
  Files                                      75       75           
  Lines                                    1874     1874           
  Branches                                  147      147           
===================================================================
  Hits                                      661      661           
  Misses                                   1164     1164           
  Partials                                   49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keitakn keitakn changed the base branch from main to release/epic36/design-renewal-2024 October 13, 2024 17:05
@keitakn keitakn marked this pull request as ready for review October 15, 2024 14:59
@keitakn keitakn merged commit 7ae16d5 into release/epic36/design-renewal-2024 Oct 15, 2024
9 checks passed
@keitakn keitakn deleted the feature/issue354/fix-margin-header-component branch October 15, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant