Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to exclude global roles from GET-roles API #146

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

shadinaif
Copy link
Collaborator

@shadinaif shadinaif commented Nov 17, 2024

feat: ability to exclude global roles from GET-roles API

  • Removing exclusion filter options: exclude_tenant_roles and exclude_course_roles
  • Replacing them with one exclusion filter option excluded_role_types that accepts any combination of global, tenant, and course

show only users having global roles ((do not show users having tenant-wise or course-specific roles, unless another role exists))

GET /api/fx/roles/v1/user_roles/?excluded_role_types=tenant,course

do not show users having global roles, unless another role exists

GET /api/fx/roles/v1/user_roles/?excluded_role_types=global

do not show users having course-specific roles, unless another role exists

GET /api/fx/roles/v1/user_roles/?excluded_role_types=course

invalid types are ignored. The following will act like the first example

GET /api/fx/roles/v1/user_roles/?excluded_role_types=atmoic,global

Related Tasks:

  • this is a breaking change, but filters for roles are not implemented yet in the front-end. Therefore, we're good 👍🏼
  • update the docs!

@shadinaif shadinaif marked this pull request as ready for review November 17, 2024 13:44
@shadinaif shadinaif force-pushed the shadinaif/global-roles-parameter branch from 3e82c27 to 0841841 Compare November 24, 2024 05:38
@shadinaif shadinaif merged commit ddea3d7 into main Nov 24, 2024
3 checks passed
@shadinaif shadinaif deleted the shadinaif/global-roles-parameter branch November 24, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants