Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signed url for data export download file #150

Merged

Conversation

tehreem-sadat
Copy link
Collaborator

@tehreem-sadat tehreem-sadat commented Nov 22, 2024

Add signed URL as downalod_url for Data export Task retrieve.

For S3, return signed URL otherwise return normal default storage url.

@tehreem-sadat tehreem-sadat force-pushed the tehreem/add_signed_url_for_s3_storage_data_export_file branch from 31480b3 to 5bd3ca7 Compare November 22, 2024 12:25
Copy link
Collaborator

@shadinaif shadinaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@shadinaif shadinaif merged commit d6b2503 into main Nov 24, 2024
3 checks passed
@shadinaif shadinaif deleted the tehreem/add_signed_url_for_s3_storage_data_export_file branch November 24, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants