fix: prevent user to triger a downlaod csv task if task details api inaccessible #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tehreem-sadat
force-pushed
the
tehreem/prevent_user_to_triger_task_if_task_details_inaccessible
branch
3 times, most recently
from
49acfed to
fa11b33
Compare
shadinaif
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
@tehreem-sadat , I'm asking to move the check to become the first one in list method. Please update it and it's good to go
Comment on lines
114
to
119
| if not self.request.fx_permission_info['download_allowed']: # type: ignore[attr-defined] | ||
| return Response( | ||
| {'detail': 'You are not permitted to use the "download" parameter'}, | ||
| status=http_status.HTTP_403_FORBIDDEN | ||
| ) | ||
|
|
There was a problem hiding this comment.
please move this check to become the first one
| request.fx_permission_info = { | ||
| 'user': request.user, | ||
| 'user_roles': user_roles, | ||
| 'is_system_staff_user': system_staff_user_flag, | ||
| 'view_allowed_roles': view_allowed_roles, | ||
| 'view_allowed_tenant_ids_any_access': tenant_ids, | ||
| 'download_allowed': download_allowed |
There was a problem hiding this comment.
Suggested change
| 'download_allowed': download_allowed | |
| 'download_allowed': download_allowed, |
| } | ||
|
|
||
| if system_staff_user_flag: | ||
| request.fx_permission_info.update({ | ||
| 'user_roles': {}, | ||
| 'download_allowed': True |
There was a problem hiding this comment.
Suggested change
| 'download_allowed': True | |
| 'download_allowed': True, |
tehreem-sadat
force-pushed
the
tehreem/prevent_user_to_triger_task_if_task_details_inaccessible
branch
from
fa11b33 to
d037808
Compare
tehreem-sadat
force-pushed
the
tehreem/prevent_user_to_triger_task_if_task_details_inaccessible
branch
from
d037808 to
554cc3c
Compare
tehreem-sadat
deleted the
tehreem/prevent_user_to_triger_task_if_task_details_inaccessible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #152