Implement From<Option> for BoltType #99
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query strings that use a placeholder
$foo
for anOption<Into<BoltType>>
cannot be constructed without first knowing if the option isNone
. This is bothersome because basic query strings for a struct can be determined withoutself
, but filling in query params requires aself
.This PR associates a query parameter of
None
to meanBoltType::Null(BoltNull)
.Does this change semantics? Before this, removing a property on an entity could be done via
SET n.prop = null
, but now it could be done withSET n.prop = $prop
. It allows a kind of silly Option<Vec<Option>> as a type.Will
serde
support take care of this (there's a draft PR)?