minor refactor

neo4j · Aug 30, 2024 · 0497016 · 0497016
1 parent 79c624c
commit 0497016
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 16 deletions.
diff --git a/algo/src/main/java/org/neo4j/gds/modularity/CommunityModularity.java b/algo/src/main/java/org/neo4j/gds/modularity/CommunityModularity.java
@@ -19,16 +19,4 @@
  */
 package org.neo4j.gds.modularity;
 
-import org.neo4j.gds.annotation.ValueClass;
-
-@ValueClass
-public interface CommunityModularity {
-
-    long communityId();
-    double modularity();
-
-    static CommunityModularity of(long communityId, double modularity) {
-        return ImmutableCommunityModularity.of(communityId, modularity);
-    }
-
-}
+public record CommunityModularity(long communityId, double modularity){}
diff --git a/algo/src/main/java/org/neo4j/gds/modularity/ModularityCalculator.java b/algo/src/main/java/org/neo4j/gds/modularity/ModularityCalculator.java
@@ -111,7 +111,7 @@ public ModularityResult compute() {
             var Kc = totalCommunityRelationships.get(mappedCommunityId);
             var modularity = (ec - Kc * Kc * (1.0 / totalRelWeight)) / totalRelWeight;
             totalModularity.add(modularity);
-            communityModularities.set(resultIndex++, CommunityModularity.of(communityId, modularity));
+            communityModularities.set(resultIndex++, new CommunityModularity(communityId, modularity));
         }
 
         return new ModularityResult(

diff --git a/algo/src/test/java/org/neo4j/gds/modularity/ModularityCalculatorTest.java b/algo/src/test/java/org/neo4j/gds/modularity/ModularityCalculatorTest.java
@@ -77,8 +77,8 @@ void compute(String communityId, int startingId) {
 
         assertThat(modularities)
             .containsExactlyInAnyOrder(
-                CommunityModularity.of(startingId, community_0_score),
-                CommunityModularity.of(startingId + 5L, community_5_score)
+                new CommunityModularity(startingId, community_0_score),
+                new CommunityModularity(startingId + 5L, community_5_score)
             );
     }