Fix 5.16 version selection

neo4j · Jan 22, 2024 · b356218 · b356218
1 parent 2c65056
commit b356218
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/...neo4j-kernel-adapter/src/main/java17/org/neo4j/gds/compat/_516/Neo4jProxyFactoryImpl.java b/...neo4j-kernel-adapter/src/main/java17/org/neo4j/gds/compat/_516/Neo4jProxyFactoryImpl.java
@@ -29,7 +29,7 @@ public final class Neo4jProxyFactoryImpl implements Neo4jProxyFactory {
 
     @Override
     public boolean canLoad(Neo4jVersion version) {
-        return version == Neo4jVersion.V_Dev;
+        return version == Neo4jVersion.V_5_16;
     }
 
     @Override

diff --git a/...ngine-adapter/src/main/java17/org/neo4j/gds/compat/_516/InMemoryStorageEngineFactory.java b/...ngine-adapter/src/main/java17/org/neo4j/gds/compat/_516/InMemoryStorageEngineFactory.java
@@ -120,7 +120,7 @@ public class InMemoryStorageEngineFactory implements StorageEngineFactory {
     static final String IN_MEMORY_STORAGE_ENGINE_NAME = "in-memory-516";
 
     public InMemoryStorageEngineFactory() {
-        StorageEngineProxyApi.requireNeo4jVersion(Neo4jVersion.V_Dev, StorageEngineFactory.class);
+        StorageEngineProxyApi.requireNeo4jVersion(Neo4jVersion.V_5_16, StorageEngineFactory.class);
     }
 
     @Override

diff --git a/...gine-adapter/src/main/java17/org/neo4j/gds/compat/_516/StorageEngineProxyFactoryImpl.java b/...gine-adapter/src/main/java17/org/neo4j/gds/compat/_516/StorageEngineProxyFactoryImpl.java
@@ -29,7 +29,7 @@ public class StorageEngineProxyFactoryImpl implements StorageEngineProxyFactory
 
     @Override
     public boolean canLoad(Neo4jVersion version) {
-        return version == Neo4jVersion.V_Dev;
+        return version == Neo4jVersion.V_5_16;
     }
 
     @Override

diff --git a/proc/sysinfo/src/test/java/org/neo4j/gds/SysInfoProcTest.java b/proc/sysinfo/src/test/java/org/neo4j/gds/SysInfoProcTest.java
@@ -87,6 +87,9 @@ class SysInfoProcTest extends BaseProcTest {
         "Neo4j 5.15",
         "Neo4j 5.15 (placeholder)",
 
+        "Neo4j 5.16",
+        "Neo4j 5.16 (placeholder)",
+
         "Neo4j DEV",
         "Neo4j DEV (placeholder)",
 
@@ -223,6 +226,14 @@ void testSysInfoProc() throws IOException {
                     "Neo4j 5.15"
                 );
                 break;
+            case V_5_16:
+                expectedCompatibilities = Set.of(
+                    "Neo4j Settings 5.x (placeholder)",
+                    "Neo4j Settings 5.x",
+                    "Neo4j 5.16 (placeholder)",
+                    "Neo4j 5.16"
+                );
+                break;
             case V_Dev:
                 expectedCompatibilities = Set.of(
                     "Neo4j Settings 5.x",