Skip to content

Commit

Permalink
some Sherlock Holmesing reveals that, while pipeline estimations are …
Browse files Browse the repository at this point in the history
…_reachable_, they are not _usable_ and therefore they are safe to delete.

Their transitive closure is ginormous, there is a whole facility we can get rid of (private preconditions), it is just beautiful. a great day at the office!
  • Loading branch information
lassewesth committed Dec 5, 2024
1 parent 0d5e1c0 commit df5a90d
Show file tree
Hide file tree
Showing 27 changed files with 8 additions and 1,917 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import org.jetbrains.annotations.Nullable;
import org.neo4j.gds.core.model.Model.CustomInfo;
import org.neo4j.gds.model.ModelConfig;
import org.neo4j.graphdb.GraphDatabaseService;

import java.nio.file.Path;
import java.util.Collection;
Expand Down Expand Up @@ -62,10 +61,6 @@ <D, C extends ModelConfig, I extends CustomInfo> Model<D, C, I> get(

Model<?, ?, ?> publish(String username, String modelName);

void checkLicenseBeforeStoreModel(GraphDatabaseService db, String detail);

Path getModelDirectory(GraphDatabaseService db);

Model<?, ?, ?> store(String username, String modelName, Path modelDir);

boolean isEmpty();
Expand Down Expand Up @@ -146,12 +141,6 @@ public boolean exists(String username, String modelName) {
return null;
}

@Override
public void checkLicenseBeforeStoreModel(GraphDatabaseService db, String detail) { }

@Override
public Path getModelDirectory(GraphDatabaseService db) { return null; }

@Override
public Model<?, ?, ?> store(String username, String modelName, Path modelDir) { return null; }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.jetbrains.annotations.Nullable;
import org.neo4j.gds.core.model.Model.CustomInfo;
import org.neo4j.gds.model.ModelConfig;
import org.neo4j.graphdb.GraphDatabaseService;

import java.nio.file.Path;
import java.util.ArrayList;
Expand Down Expand Up @@ -145,18 +144,6 @@ public boolean exists(String username, String modelName) {
);
}

@Override
public void checkLicenseBeforeStoreModel(GraphDatabaseService db, String detail) { }

@Override
public Path getModelDirectory(org.neo4j.graphdb.GraphDatabaseService db) {
throw new IllegalStateException(
"There is no model directory path. Storing models is not available in openGDS. " +
"Please consider licensing the Graph Data Science library. " +
"See documentation at https://neo4j.com/docs/graph-data-science/"
);
}

@Override
public Model<?, ?, ?> store(String username, String modelName, Path modelDir) {
throw new IllegalStateException(
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading

0 comments on commit df5a90d

Please sign in to comment.