-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure imperatively #177
Draft
shartte
wants to merge
1
commit into
main
Choose a base branch
from
imperative-config
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
src/main/java/net/neoforged/moddevgradle/dsl/ImmutableModdingVersions.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
package net.neoforged.moddevgradle.dsl; | ||
|
||
import groovyjarjarantlr4.v4.runtime.misc.Nullable; | ||
|
||
public record ImmutableModdingVersions(@Nullable String neoForgeVersion, @Nullable String neoFormVersion) { | ||
} |
41 changes: 41 additions & 0 deletions
41
src/main/java/net/neoforged/moddevgradle/dsl/ModdingVersionSettings.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package net.neoforged.moddevgradle.dsl; | ||
|
||
import org.gradle.api.provider.ListProperty; | ||
import org.gradle.api.tasks.SourceSet; | ||
import org.jetbrains.annotations.ApiStatus; | ||
import org.jetbrains.annotations.Nullable; | ||
|
||
public abstract class ModdingVersionSettings { | ||
@Nullable | ||
private String neoForgeVersion; | ||
|
||
@Nullable | ||
private String neoFormVersion; | ||
|
||
/** | ||
* NeoForge version number. You have to set either this or {@link #setNeoFormVersion}. | ||
*/ | ||
public void setNeoForgeVersion(String version) { | ||
this.neoForgeVersion = version; | ||
} | ||
|
||
/** | ||
* You can set this property to a version of <a href="https://projects.neoforged.net/neoforged/neoform">NeoForm</a> | ||
* to either override the version used in the version of NeoForge you set, or to compile against | ||
* Vanilla artifacts that have no NeoForge code added. | ||
*/ | ||
public void setNeoFormVersion(String version) { | ||
this.neoFormVersion = version; | ||
} | ||
|
||
/** | ||
* Contains the list of source sets for which access to Minecraft classes should be configured. | ||
* Defaults to the main source set, but can also be set to an empty list. | ||
*/ | ||
public abstract ListProperty<SourceSet> getEnabledSourceSets(); | ||
|
||
@ApiStatus.Internal | ||
public ImmutableModdingVersions toImmutable() { | ||
return new ImmutableModdingVersions(neoForgeVersion, neoFormVersion); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this may be the wrong Nullable (also can I just say how obnoxious all those shaded groovy deps can be?)