-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace NG use by a custom neodev plugin built on top of NFRT and MDG #1485
base: 1.21.x
Are you sure you want to change the base?
Conversation
Last commit published: 14807ec48523497209e756f609225f9527a0c1c7. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1485' // https://github.com/neoforged/NeoForge/pull/1485
url 'https://prmaven.neoforged.net/NeoForge/pr1485'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1485
cd NeoForge-pr1485
curl -L https://prmaven.neoforged.net/NeoForge/pr1485/net/neoforged/neoforge/21.3.30-beta-pr-1485-features-moddevgradle/mdk-pr1485.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
build.gradle
Outdated
// Remove src/ sources from the root project. They are used in the neoforge subproject. | ||
sourceSets { | ||
main { | ||
java { | ||
srcDirs = [] | ||
} | ||
resources { | ||
srcDirs = [] | ||
} | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this previously done in NG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it wasn't necessary because the java plugin wasn't getting applied to the root project? I'm not sure why I had to apply java, I think it's for the neodev plugin. We shouldn't need the neodev plugin for the root project though.
build.gradle
Outdated
@@ -3,6 +3,7 @@ import java.util.regex.Pattern | |||
|
|||
plugins { | |||
id 'net.neoforged.gradleutils' version '3.0.0' | |||
id 'net.neoforged.neodev' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be apply false
?
33306a0
to
a706b07
Compare
a706b07
to
625530a
Compare
This PR replaces our use of NG by a custom plugin that is based on NFRT and MDG, and lives in the
buildSrc/
folder.The main advantages are as follows:
TODO:
io.codechicken
variant.