Add c:obsidians/normal
and c:obsidians/crying
subtags
#1556
+53
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was a request from some users.
The original change to having Crying Obsidian in the
c:obsidians
tag was required as it is obsidian and excluding it would've been illogical and completely arbitrary. Much like saying brown mushroom shouldn't be in a mushroom tag because it is a light block despite a mushroom.However, adding subtags is more ideal for narrowing down and clarifying usages. In this case, recipes can target
c:obsidians/normal
and won't have to worry about other mod's special rare obsidians making it inside too. This is the same setup that we do forc:cobblestones/normal
,c:cobblestones/mossy
,c:cobblestones/infested
so we have precedence for using normal for the default regular block.Closes #1548