Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Fix nametag set in RenderNameTagEvent.CanRender not being used and not being able to bypass nametag render range #1675

Open
wants to merge 1 commit into
base: 1.21.x
Choose a base branch
from

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Nov 9, 2024

This PR fixes the RenderNameTagEvent.CanRender receiving potentially the wrong value for the nametag, the nametag set by listeners being ignored and listeners not being able to bypass the nametag render distance limit of 64 blocks.

Fixes #1667

@XFactHD XFactHD added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 9, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 9, 2024

  • Publish PR to GitHub Packages

Last commit published: 99ef9ac5ad8be46927a41ceb3f34561e3411626e.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1675' // https://github.com/neoforged/NeoForge/pull/1675
        url 'https://prmaven.neoforged.net/NeoForge/pr1675'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1675.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1675
cd NeoForge-pr1675
curl -L https://prmaven.neoforged.net/NeoForge/pr1675/net/neoforged/neoforge/21.3.14-beta-pr-1675-render_nametag_event/mdk-pr1675.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@neoforged-compatibility-checks

@XFactHD, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 99ef9ac5ad8be46927a41ceb3f34561e3411626e.

neoforge (:neoforge)

  • net/neoforged/neoforge/client/event/RenderNameTagEvent
    • <init>(Lnet/minecraft/client/renderer/entity/state/EntityRenderState;Lnet/minecraft/network/chat/Component;Lnet/minecraft/client/renderer/entity/EntityRenderer;F)V: ⚠ API method was removed
    • originalContent:Lnet/minecraft/network/chat/Component;: ❗ API field was removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.21.3] Custom name tag component set in RenderNameTagEvent$CanRender is ignored
1 participant