-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Location as a field of YMDFlag #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevM
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking. Just asking for more tests and a concern about one of the utility methods.
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
…e happens Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
Signed-off-by: Kevin Miller <[email protected]>
KevM
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Add Location as a field of YMDFlag, refactor with public helpers Signed-off-by: Kevin Miller <[email protected]> * Add examples and Taskfile Signed-off-by: Kevin Miller <[email protected]> * More interface refinement Signed-off-by: Kevin Miller <[email protected]> * Remove Location field and simplify interface, limiting where auto-date happens Signed-off-by: Kevin Miller <[email protected]> * add yyyymmdd validation tests Signed-off-by: Kevin Miller <[email protected]> * moar tests Signed-off-by: Kevin Miller <[email protected]> * Trying things out Signed-off-by: Kevin Miller <[email protected]> * Move to newer test action Signed-off-by: Kevin Miller <[email protected]> * add clarifying comment Signed-off-by: Kevin Miller <[email protected]> * fix linter issue Signed-off-by: Kevin Miller <[email protected]> * More action cleanup * task update also updates tests --------- Signed-off-by: Kevin Miller <[email protected]> Co-authored-by: Kevin Miller <[email protected]> Signed-off-by: Kevin Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
time.Time
carries time data and atime.Location
,ymdflag.YMDFlag
only had theyyyymmdd
time data and no location. This made the interface confusing with respect to location. This commit adds atime.Location
field and methods for dealing with it. Conversions to and fromtime.Time
respect theLocation
.This is breaking interface change -- but we have no version tags on this package yet.