Update examples for v1.0 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjvalencik
commented
Jan 29, 2024
| @@ -9,3 +9,6 @@ members = [ | |||
|
|
|||
| [profile.release] | |||
| lto = true | |||
|
|
|||
| [patch.crates-io] | |||
| neon = { git = "https://github.com/neon-bindings/neon.git" } | |||
There was a problem hiding this comment.
Need to delete this once 1.0 is published.
kjvalencik
commented
Jan 29, 2024
| let data = guard.get_mut(); | ||
| let output = data.clone(); | ||
| let output = JsUint8Array::from_slice(&mut cx, data)?; |
There was a problem hiding this comment.
Since we were already cloning, we can get very similar ergonomics and performance by copying directly into the Uint8Array instead of using an external.
dherman
approved these changes
Jan 29, 2024
| @@ -135,7 +134,7 @@ impl Database { | |||
| let name = cx.argument::<JsString>(0)?.value(&mut cx); | |||
|
|
|||
| // Get the `this` value as a `JsBox<Database>` | |||
| let db = cx.this().downcast_or_throw::<JsBox<Database>, _>(&mut cx)?; | |||
| let db = cx.this::<JsBox<Database>>()?; | |||
There was a problem hiding this comment.
General specialization would be awesome here. We could have a blanket impl for downcasting T, but a specialized case for when T implements Value.
This would allow you to skip the JsBox here and assume it from an out param.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can make some further improvements when the
argsAPI lands.