Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generic type parameters #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve generic type parameters #69

wants to merge 1 commit into from

Conversation

alpha-tango-kilo
Copy link
Contributor

Use AsRef<str> instead of Into<String> where sensible to do so
Saves allocations and/or taking ownership
Potentially a breaking change on some really weird types

@neonmoe neonmoe added this to the 3.0 milestone Jan 17, 2022
@alpha-tango-kilo
Copy link
Contributor Author

Rebased on latest master and resolved conflicts. Massively reduced the scope of the changes as there was no harm in using Into<String>/Into<URL> in a lot of places since an owned value was going to be needed anyway (like with all the Request::new aliases)

@alpha-tango-kilo
Copy link
Contributor Author

CI failure looks to be #93

@neonmoe
Copy link
Owner

neonmoe commented Mar 18, 2023

It's been fixed now, rebasing onto the newest master should make the CI pass. The PR looks great!

@alpha-tango-kilo
Use AsRef<str> instead of Into<URL>
140a982 
Saves allocations and/or taking ownership
Potentially a breaking change on some really weird types
@alpha-tango-kilo
Copy link
Contributor Author

Thanks for the fix, all rebased!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alpha-tango-kilo @neonmoe