Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Implement component for displaying Favicons in frontend #176

Open
wants to merge 4 commits into
base: 8.4
Choose a base branch
from

Conversation

crydotsnake
Copy link
Member

No description provided.

@mhsdesign
Copy link
Member

Thanks for your work ^^ Is it normal that this seems so complex / verbose?

I mean this is supposed to be a exemplary demo - im not sure if this wouldnt scare people away :P

... But if this is the way. I would not oppose.

image

@crydotsnake
Copy link
Member Author

crydotsnake commented Jul 20, 2023

Well. You could also use a fluid file with the HTML for the favicons. And a fusion file that inherits from Neos.Fusion:Template and just has the package and the Fluid file as the templatePath as propertys.

But the idea as I have solved it here came to me as the first thought.

But both solutions are not complex at all IMO 🤔

Copy link
Member

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today you don't need so many icons anymore, see https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs or other articles. Also the manifest should be adjustable or have safe placeholders, as it contains something about Sandstorm and Neos and people might just copy it.
To make the manifest adjustable, similar to the Robots.txt in Neos.Seo would actually be a cool example I think. Also I would not use the ResourceUri but directly use the StaticResource Eelhelper in the Tag. They should anyway be a bit more individual and not all have the 32px size attribute.

@crydotsnake
Copy link
Member Author

Today you don't need so many icons anymore, see https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs or other articles.

First i thought about using a favicon generator. For example: https://realfavicongenerator.net/

But was not sure if this would be a good solution. Wdyt?

@Sebobo
Copy link
Member

Sebobo commented Jul 21, 2023

Why not just remove the tags you don't need and keep the rest and just do a few adjustments?
Don't fully understand your question regarding the generator and how it would help?

@Sebobo
Copy link
Member

Sebobo commented Sep 16, 2024

Should target 8.4 though

@crydotsnake crydotsnake changed the base branch from 8.3 to 8.4 September 16, 2024 12:54
@crydotsnake
Copy link
Member Author

Should target 8.4 though

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants