-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Implement component for displaying Favicons in frontend #176
base: 8.4
Are you sure you want to change the base?
Conversation
Well. You could also use a fluid file with the HTML for the favicons. And a fusion file that inherits from But the idea as I have solved it here came to me as the first thought. But both solutions are not complex at all IMO 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today you don't need so many icons anymore, see https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs or other articles. Also the manifest should be adjustable or have safe placeholders, as it contains something about Sandstorm and Neos and people might just copy it.
To make the manifest adjustable, similar to the Robots.txt in Neos.Seo would actually be a cool example I think. Also I would not use the ResourceUri but directly use the StaticResource Eelhelper in the Tag. They should anyway be a bit more individual and not all have the 32px size attribute.
First i thought about using a favicon generator. For example: https://realfavicongenerator.net/ But was not sure if this would be a good solution. Wdyt? |
Why not just remove the tags you don't need and keep the rest and just do a few adjustments? |
Should target 8.4 though |
Done. |
No description provided.