Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature workspace module with role assignments #5441

Draft
wants to merge 3 commits into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

Followup to #5132 by reintroducing the WIP role editing which was reverted via 4aed441

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign marked this pull request as draft January 17, 2025 13:05
@mhsdesign mhsdesign marked this pull request as draft January 17, 2025 13:05
@github-actions github-actions bot added the 9.0 label Jan 17, 2025
try {
$this->workspaceService->createSharedWorkspace(
$contentRepositoryId,
$workspaceName,
$title,
$description,
$baseWorkspace,
$assignments
WorkspaceRoleAssignments::createForSharedWorkspace(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be discussed: do we need some explicit initial workspace assignments on creation or are we fine to create shared by default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant