ci: check for deprecated util functions #3462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
force-pushed
the
deprutil
branch
2 times, most recently
from
630ca8a to
b1fd0e5
Compare
21 tasks
dundargoc
approved these changes
Nov 26, 2024
|
Wait, isn't it supposed to be util.path.dirname? |
dundargoc
reviewed
Nov 26, 2024
.github/ci/run_sanitizer.sh
Outdated
| echo "see: https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#adding-a-server-to-lspconfig." | ||
| exit 1 | ||
| fi | ||
|
|
||
| SEARCH_PATTERN='(util\.dirname)' |
There was a problem hiding this comment.
util.path.dirname or path.dirname
Also seems like we already check for this in the check above it
There was a problem hiding this comment.
the above check is something about "root" specifically. this new check will be a place to catch all deprecated functions
There was a problem hiding this comment.
I know, it just caught my eye since we check for the same function twice, the context is just different. Not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.dirnameis deprecated (and banned in configs) since #3460Example
see https://github.com/neovim/nvim-lspconfig/actions/runs/12033646442/job/33548305477?pr=3462 for an example run.