refactor: deprecate util.path.is_descendant #3524
Conversation
| @@ -1,5 +1,9 @@ | |||
| local util = require 'lspconfig.util' | |||
|
|
|||
| local function is_descendant(root, path) | |||
| return vim.startswith(vim.fs.normalize(path), vim.fs.normalize(root)) | |||
There was a problem hiding this comment.
If we don't have an answer in vim.fs then we probably should wait until we do. Maybe it could be named vim.fs.has()
There was a problem hiding this comment.
IMO something like vim.fs.relpath that returns the path relative to another path (similar to :~ in fnamemodify but generalized) would probably be more useful. I imagine it'd return nil in the case it isn't a descendant?
Actually, most uses of is_descendant in our configs could already be replaced by fnamemodify, it is only rust_analyzer that requires a generalized is_descendant. We could move this function to the rust_analyzer file and just use fnamemodify for the other?
There was a problem hiding this comment.
We could but it would be better to get stuff into vim.fs so that we can use it in the configs[1], instead of having to redo the configs again ...
[1] (for Phase 2 of #3494 , where we tag a final legacy release for Nvim 0.10 or older)
dundargoc
force-pushed
the
refactor/is_descendant
branch
from
e6865ea to
075429f
Compare
|
Closing as some functionality is needed in core for this to be smooth. |
Work on #2079.