refactor!: remove public interface of util.path.traverse_parents #3525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dundargoc
force-pushed
the
refactor/traverse_parents
branch
from
eed9a5b to
c6586b5
Compare
dundargoc
changed the title
|
Removed the public function since none of the configs actually use this and I don't think it's used much in the wild anyway, so figured this should be fine. If this is too breaking lemme know and I'll instead focus on adding functionality to core vim.fs instead. |
|
If this function is not used internally, it can be safely removed. I think we never recommend any configuration to use the function encapsulated here. vim.fs is always our direction |
glepnir
approved these changes
Dec 23, 2024
justinmk
approved these changes
Dec 23, 2024
Related: neovim/neovim#25154 |
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #2079.