Rename "includeHeader" option to "include_header"

neoxia · Oct 13, 2017 · dfc600a · dfc600a
1 parent ad95ada
commit dfc600a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -131,6 +131,6 @@ The default options are the following.
     'encoding' => 'WINDOWS-1252',
     'delimiter' => ';',
     'quoted' => true,
-    'includeHeader' => true,
+    'include_header' => true,
 ]
 ```
diff --git a/src/Neoxia/Routing/ResponseFactory.php b/src/Neoxia/Routing/ResponseFactory.php
@@ -43,7 +43,7 @@ public function parseOptions(array $customOptions)
             'encoding' => 'WINDOWS-1252',
             'delimiter' => ';',
             'quoted' => true,
-            'includeHeader' => true,
+            'include_header' => true,
         ];
 
         return array_merge($baseOptions, $customOptions);
@@ -78,7 +78,7 @@ protected function formatCsv($data, array $options)
         } else {
             $csvArray = [];
 
-            if ( $options['includeHeader']) {
+            if ( $options['include_header']) {
                 $this->addHeaderToCsvArray($csvArray, $data, $options);
             }
 

diff --git a/tests/ResponseFactoryTest.php b/tests/ResponseFactoryTest.php
@@ -166,7 +166,7 @@ public function testCsvCanFormatWithoutHeader()
     {
         $data = [['first_name' => 'John', 'last_name' => 'Doe']];
 
-        $response = $this->responseFactory->csv($data, 200, [], ['includeHeader' => false]);
+        $response = $this->responseFactory->csv($data, 200, [], ['include_header' => false]);
 
         $this->assertCsvResponseIsValidAndEquals($response, "\"John\";\"Doe\"");
     }