-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added All pixel Sampler #3031
base: main
Are you sure you want to change the base?
Added All pixel Sampler #3031
Conversation
A sampler that selects a specific image and samples all pixels from that image
Just some side question: I am also curious why we didn't have something like AllPixelSampler for implementing next_eval_image. I spent sometime digging into the code and realized that we currently use RandIndicesEvalDataloader to select a random camera and use get_outputs_for_camera which involves a nested call of camera.generate_rays. The process to obtain rays is not following the typical workflow we set for next_train() and next_eval(), where a pixel sampler is used. |
That makes sense. I didn't notice the RandIndicesEvalDataloader earlier. The AllPixelSampler implementation makes it compatible with the next_train() and next_eval() function in the VanillaDataManager class. Both functions assert a requirement for a pixel sampler. |
A sampler that selects a specific image and samples all pixels from that image.
I believe this could be a useful class where the neural field is optimised per image. This is used in nerf2mesh, where the pixels must be sampled from a single image to generate rays, which are then used to rasterise the image from the coarse mesh.
I use this pixel sampler in my implementation of nerf2mesh using nerfstudio.
Happy to make any edits if required.