Add viewerplot element #3129
Draft
Add viewerplot element #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chungmin99
commented
May 8, 2024
•
chungmin99
commented
- make documentation
- fix plotsize issue (needs refresh, otherwise the width >> panel width -- perhaps a viser race condition?)
kerrj
reviewed
May 9, 2024
nerfstudio/viewer/viewer_elements.py
Outdated
| return self.gui_handle.figure | ||
|
|
||
| @figure.setter | ||
| def figure(self, figure: go.Figure): |
There was a problem hiding this comment.
it would be nice to automatically apply the dark mode+aspect to new figures as well, so that the user doesn't have to call dark_mode and aspect every time they update/change something
There was a problem hiding this comment.
aspect doesn't need to be set for new figures, but you're right about dark_mode. 👍
There was a problem hiding this comment.
Should be addr'ed in ca04cbc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.