Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to issue #3405. Credit to hoanle for finding the issue.
Background:
OccGridEstimator uses different levels of AABBs to determine where to sample the points from with varying levels of detail.
But those samples outside the original AABB are not used anyway if we disable the scene contraction:
Since the positions (if distortion is disabled) are taken from a normalized standpoint until the
self.aabb
parameter is passed in.Problem:
The problem is that if we begin with the
scene_aabb
, the outermost AABB, we will not use any of the other resolutions in our enlargement calculations. Therefore, we need to start from the innermost AABB depending on the number of levels.