Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progressbar component #238

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Add progressbar component #238

merged 6 commits into from
Jul 16, 2024

Conversation

jkulhanek
Copy link
Contributor

Adds a simple progress bar component.

@jkulhanek jkulhanek requested a review from brentyi July 9, 2024 15:25
brentyi
brentyi approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful!

I made some minor changes, notably renaming add_progressbar => add_progress_bar and loading => animated (to match Mantine naming?).

@brentyi
Copy link
Collaborator

brentyi commented Jul 11, 2024

@ginazhouhuiwu this might also be cool to integrate into nerfstudio-project/nerfstudio#3220

@brentyi brentyi merged commit fbcb430 into main Jul 16, 2024
9 checks passed
@brentyi brentyi deleted the jkulhanek/progress-bar branch July 16, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkulhanek @brentyi