Allow publishing docker images from PR #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshoes
approved these changes
Oct 31, 2024
jjcarstens
force-pushed
the
allow-pr-docker-push
branch
4 times, most recently
from
69a4d6d
to
ed94a26
Compare
This is sometimes useful for testing PRs in external systems as needed
jjcarstens
force-pushed
the
allow-pr-docker-push
branch
from
9f661eb
to
2327e62
Compare
|
I'm wondering if we publish on a PR, without needing to check for |
|
Do we want to publish an image for every commit? It seems a bit excessive, especially with some recent PRs that had 20+ commits. Though I'm not opposed for making it easier... |
|
Josh and I spoke in slack - Merging for now and if we want to build every commit later, easy change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sometimes useful for testing PRs in external systems as needed
You can either manually trigger a publish in the
Actionstable and run the workflow for your branch or include[publish]in any commit message to have it sent through