Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Universal Asset Notation #335
base: master
Are you sure you want to change the base?
RFC: Universal Asset Notation #335
Changes from 2 commits
8cbc400
c973ae6
1046744
834e9aa
4b5fed8
828da43
a092218
adeff70
7e55cae
73d8d7b
bcb2279
b157fc1
3baa39e
c47994f
10dec1e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The asset symbol should not be case restricted, since some ERC20 do have a lowercase symbol, like
stETH
(staked ETH), and some wrapped tokens, likewETH
,wMANA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "Forcebridge" should be written as "Force Bridge"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method of translating
|
tovia
and.
tofrom
helps readers to understand the notation and read the symbol in human language. I think it worths a section here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you suggest the change with a PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So
CKB
in CKB DApps should be renamed toCKB.ckb
? or we can make a convention that<asset-symbol>
without any annotation indicates that it is born on the current chain backing the DApp.