Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version catalog for storing dependencies #56

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bejibx
Copy link

@bejibx bejibx commented Dec 23, 2024

Minified version of #50 with only libs.versions.toml support

@bejibx
Copy link
Author

bejibx commented Dec 23, 2024

There is one place where version catalog can not be used:

implementation("org.jetbrains.kotlinx:kotlinx-coroutines-test:1.9.0-RC.2")

I'm suggesting to instead explicitly declare this dependency in every place where convention plugin is used

Copy link
Owner

@nesk nesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! 🙏 Could you add the missing comment?

I think you're right for kotlinx-coroutines-test, we can import it everywhere we need to keep the version inside the catalog. (I can write the commit if you want)

}

repositories {
mavenCentral()
}

tasks.named<Wrapper>("wrapper") {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment here to explain what this code does?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants