Skip to content

Commit

Permalink
Improve gemspec
Browse files Browse the repository at this point in the history
- Relax dependencies to allow newer versions
- Move development dependencies to Gemfile

This is a new best practice and will also avoid this warning:

```
A gemspec development dependency (riot, ~> 0.12.3) is being overridden by a Gemfile dependency (riot, >= 0).
This behaviour may change in the future. Please remove either of them, or make sure they both have the same requirement
```

Ref: https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies
  • Loading branch information
tagliala committed Nov 14, 2024
1 parent effe634 commit 20f9b2f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
9 changes: 8 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,16 @@ group :test do
gem 'sqlite3', sqlite3_version
gem 'sinatra', '>= 1.2.0'
gem 'hashie'
gem 'riot'
end

group :development, :test do
gem 'bson', '< 2' # FIXME: Versions >= 2 make tests fail
# gem 'debugger'
gem 'msgpack'
gem 'oj'
gem 'plist'
gem 'rake'
gem 'riot'
gem 'rr'
gem 'tilt'
end
9 changes: 0 additions & 9 deletions rabl.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,4 @@ Gem::Specification.new do |s|
else
s.add_dependency "activesupport", '>= 2.3.14'
end

s.add_development_dependency 'riot', '~> 0.12.3'
s.add_development_dependency 'rr'
s.add_development_dependency 'rake'
s.add_development_dependency 'tilt'
s.add_development_dependency 'oj'
s.add_development_dependency 'msgpack', '~> 1.0.0'
s.add_development_dependency 'bson', '~> 1.7.0'
s.add_development_dependency 'plist'
end

0 comments on commit 20f9b2f

Please sign in to comment.