Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/integration tests #751

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Chore/integration tests #751

wants to merge 6 commits into from

Conversation

tagliala
Copy link
Collaborator

@tagliala tagliala commented Dec 7, 2021

No description provided.

@tagliala tagliala force-pushed the chore/integration-tests branch 5 times, most recently from b156145 to a4d5bed Compare December 8, 2021 00:18
@tagliala tagliala mentioned this pull request Dec 8, 2021
@tagliala tagliala force-pushed the chore/integration-tests branch from a4d5bed to 9c704ed Compare December 8, 2021 12:32
@nesquena
Copy link
Owner

nesquena commented Dec 30, 2021

@tagliala Let me know when this is ready and I can release a new cut of RABL, thanks so much for working on this

@tagliala
Copy link
Collaborator Author

Hi @nesquena, yes please, if you can release a new version, that will be compatible with Rails 7

If someone will notice issues not covered by specs, we will try to address them with hotfixes

@nesquena
Copy link
Owner

Hi @nesquena, yes please, if you can release a new version, that will be compatible with Rails 7

If someone will notice issues not covered by specs, we will try to address them with hotfixes

Great, thanks again for helping to maintain RABL 🙏 I released rabl 0.15.0 just now. Ping me if you need anything else

@tagliala
Copy link
Collaborator Author

Great, thanks again for helping to maintain RABL 🙏 I released rabl 0.15.0 just now. Ping me if you need anything else

Thanks!

Will do that.

I have an idea to improve integration tests by automatically generating dummy apps and copy some files instead of having them checked in the repository, but I do not have too much time to invest on Rabl at the moment.

Also, I'm not sure how to deal with Sinatra and Padrino, I wasn't able to run existing specs at the moment. Maybe I can work on a rails specific workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants