Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): use process.env.PORT by default #394

Closed
wants to merge 1 commit into from
Closed

feat(): use process.env.PORT by default #394

wants to merge 1 commit into from

Conversation

ahasall
Copy link

@ahasall ahasall commented May 25, 2020

This will make sure that an application generated by the NestJS can be deployed to the cloud without any modification

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

The default port is 3000.
Issue Number: N/A

What is the new behavior?

The default port is process.env.PORT and will fallback to 3000

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This will make sure that an application generated by the NestJS can be deployed to the cloud without any modification
@ahasall
Copy link
Author

ahasall commented May 25, 2020

Oh didn't see PR #288

@kamilmysliwiec
Copy link
Member

hey @ahasall! long time no speak :) hope you're doing well. Since we have a similar PR opened already (#288), I'll close this one

@ahasall ahasall deleted the port branch June 18, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants