Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindConfigHelpers method adds unwanted methods to helpers object #72

Open
bashleigh opened this issue Feb 5, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@bashleigh
Copy link
Collaborator

bashleigh commented Feb 5, 2019

Issue type:

[ ] question
[x] bug report
[ ] feature request
[ ] documentation issue

nestjs-config version

@latest

@nestjs/common+core or other package versions

  • @nestjs/common: 5.6.2
  • @nestjs/core: 5.6.2

Excepted behavior

Classes to not be scanned for all methods

Actual behavior or outcome (for issue)

Currently the bindConfigHelpers method will 'scan' all object keys within a config file object. Which results in unwanted methods being added to the helpers object
screenshot 2019-02-05 at 15 46 26

We need to make a decision on how to keep the existing functionality and avoid this outcome. First seen here #69 #71

Replication/Example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants