Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added to condition to avoid null objects #71

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

bashleigh
Copy link
Collaborator

@bashleigh bashleigh commented Feb 5, 2019

This is a quick fix for #69. However I feel like there should be a decision made as to how we're going to avoid unwanted methods being added the the helper function array #72

#64 Also related to this.

@bashleigh bashleigh added the bug Something isn't working label Feb 5, 2019
@bashleigh bashleigh self-assigned this Feb 5, 2019
@bashleigh bashleigh requested review from fenos and shekohex February 5, 2019 15:50
@coveralls
Copy link

coveralls commented Feb 5, 2019

Pull Request Test Coverage Report for Build 187

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 97.0%

Totals Coverage Status
Change from base Build 178: 0.05%
Covered Lines: 145
Relevant Lines: 145

💛 - Coveralls

Copy link
Member

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK, but imo it's not a solution, i think i would open another pr to try to validate null at Compile Time. BTW, good job

@bashleigh bashleigh merged commit 38b1a8d into master Feb 7, 2019
@bashleigh bashleigh deleted the fix/config-binding-helper branch February 7, 2019 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants