-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per-Script Worker Queue Setting #16552
Closed
jchambers2012
wants to merge
17
commits into
netbox-community:develop
from
jchambers2012:script_rq_queue_name
Closed
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2455660
Update scripts.py with rq_queue_name
jchambers2012 259cb5a
Update jobs.py add rq_queue_name
jchambers2012 99d2593
Update jobs.py
jchambers2012 1bc636d
Update jobs.py Lint
jchambers2012 c7970f0
Merge branch 'netbox-community:develop' into script_rq_queue_name
jchambers2012 3146a48
Add q_queue_name to docs
b203c9d
Adding rq_queue_name to API and Views
8409c97
Default Logic if Queue does not exist
a28810a
wording
d8868ed
wording
5676c4a
Changes requested by arthanson
jchambers2012 421f1aa
PEP8 Fixes
jchambers2012 e2f2799
Merge branch 'netbox-community:develop' into script_rq_queue_name
jchambers2012 d34a87f
Add logging for django_rq errors
9b60d46
Updated to include RQ reconfigure warning
470e48e
PEP8 Fix
8970c8d
Merge branch 'netbox-community:develop' into script_rq_queue_name
jchambers2012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #16927 I'm introducing a general purpose job API used by NetBox and made available for plugins. A minor background for this is abstraction to decouple plugins from using Redis directly, making future changes possible. Therefore I'd like to suggest not using parameter names related to Redis queues, i.e. just using something like
queue
instead ofrq_queue_name
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with whatever Netbox wants to use for name, be it
queue
,worker_queue
orjob_queue
. But I won't make any changes right now till the Netbox maintainers pick the language that is preferred for this.