Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all #17211

Draft
wants to merge 14 commits into
base: feature
Choose a base branch
from
Draft

Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all #17211

wants to merge 14 commits into from

Conversation

DanSheps
Copy link
Member

@DanSheps DanSheps commented Aug 20, 2024 •
edited
Loading

Fixes: #15924 and #17249 - Prevent API payload from allowing tagged_vlans while interface mode is set to taged-all and prevent API from allowing untagged_vlan when no 802.1q mode is set.

  • Prevent API (or any API write function) which includes untagged_vlan with interface 802.1q mode is not set
  • Prevent API (or any API write function) which includes tagged_vlans with interface mode set to tagged-all

@DanSheps DanSheps self-assigned this Aug 20, 2024
@DanSheps DanSheps added the type: bug A confirmed report of unexpected behavior in the application label Aug 20, 2024
@DanSheps DanSheps requested review from jeremystretch and removed request for jeremystretch August 21, 2024 20:17
@jeremystretch jeremystretch removed the type: bug A confirmed report of unexpected behavior in the application label Aug 23, 2024
jeremystretch
jeremystretch requested changes Aug 23, 2024
View reviewed changes
netbox/dcim/api/serializers_/device_components.py Outdated Show resolved Hide resolved
netbox/dcim/models/device_components.py Outdated Show resolved Hide resolved
@DanSheps
Make changes to validation to account for M2M not being available und…
d159547 
…er model in addition to not being able to check incoming vlans under same model.
@DanSheps DanSheps linked an issue Aug 27, 2024 that may be closed by this pull request
Adding the untagged_vlan property to dcim.interface using the API that isn't in mode tagged fails without error #17249
Closed
@jeremystretch jeremystretch mentioned this pull request Aug 27, 2024
Closed
@DanSheps DanSheps changed the title Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to taged-all Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all Aug 30, 2024
@DanSheps DanSheps changed the base branch from develop to feature August 30, 2024 02:34
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 15, 2024
@DanSheps DanSheps removed the pending closure Requires immediate attention to avoid being closed for inactivity label Sep 16, 2024
@DanSheps
Copy link
Member Author

Per maintainer meeting, need to refactor logic to try and streamline the checks.

@DanSheps DanSheps marked this pull request as draft September 24, 2024 13:49
@DanSheps
Merge branch 'feature' of https://github.com/netbox-community/netbox …
8dd6119 
…into 15924-fix-api-interface-patch-tagged-all-mode
@DanSheps DanSheps added the status: blocked Another issue or external requirement is preventing implementation label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees

@DanSheps DanSheps

Labels
status: blocked Another issue or external requirement is preventing implementation
Projects
None yet
Milestone
No milestone
2 participants
@DanSheps @jeremystretch