Fixes: 17292 - Detect infinite loop condition while iterating terminations in CablePath.from_origin #17293
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
DanSheps
removed
the
pending closure
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
DanSheps
reviewed
Nov 5, 2024
Comment on lines
+722
to
+727
| num_elements_added = len(path) - len(prev_path) | ||
| prev_elements_added = prev_path[-num_elements_added:] | ||
| elements_added = path[-num_elements_added:] | ||
| if elements_added == prev_elements_added: | ||
| logger.warning('Infinite loop detected while updating cable path trace') | ||
| break |
There was a problem hiding this comment.
If I am understanding this correctly, this iwll only detect a loop in the last element, not if it is 3 elements back
Eg:
FP1 <> RP1 <> RP2 <> FP2 <> FP3 <> RP3 <> RP4 <> FP4 <> FP1
Could youy confirm this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17292
Compares each iteration through
terminationsinfrom_originto the previous iteration. If the path elements added in the current iteration are the same as those that were added in the previous iteration, this is an infinite loop and we log the issue and break out of the loop.