fix: remove not used otlp metrics (#38)

netboxlabs · Dec 26, 2024 · b2f3d7f · b2f3d7f
1 parent 57023bd
commit b2f3d7f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/agent/backend/devicediscovery/device_discovery.go b/agent/backend/devicediscovery/device_discovery.go
@@ -6,7 +6,6 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"strings"
 	"time"
 
 	mqtt "github.com/eclipse/paho.mqtt.golang"
@@ -52,8 +51,7 @@ type deviceDiscoveryBackend struct {
 	cancelFunc context.CancelFunc
 	ctx        context.Context
 
-	mqttClient       *mqtt.Client
-	otlpMetricsTopic string
+	mqttClient *mqtt.Client
 }
 
 type info struct {
@@ -89,10 +87,8 @@ func (d *deviceDiscoveryBackend) Configure(logger *zap.Logger, repo policies.Pol
 	return nil
 }
 
-func (d *deviceDiscoveryBackend) SetCommsClient(agentID string, client *mqtt.Client, baseTopic string) {
+func (d *deviceDiscoveryBackend) SetCommsClient(_ string, client *mqtt.Client, _ string) {
 	d.mqttClient = client
-	otelBaseTopic := strings.Replace(baseTopic, "?", "otlp", 1)
-	d.otlpMetricsTopic = fmt.Sprintf("%s/m/%c", otelBaseTopic, agentID[0])
 }
 
 func (d *deviceDiscoveryBackend) Version() (string, error) {

diff --git a/agent/backend/networkdiscovery/network_discovery.go b/agent/backend/networkdiscovery/network_discovery.go
@@ -6,7 +6,6 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
-	"strings"
 	"time"
 
 	mqtt "github.com/eclipse/paho.mqtt.golang"
@@ -52,8 +51,7 @@ type networkDiscoveryBackend struct {
 	cancelFunc context.CancelFunc
 	ctx        context.Context
 
-	mqttClient       *mqtt.Client
-	otlpMetricsTopic string
+	mqttClient *mqtt.Client
 }
 
 type info struct {
@@ -89,10 +87,8 @@ func (d *networkDiscoveryBackend) Configure(logger *zap.Logger, repo policies.Po
 	return nil
 }
 
-func (d *networkDiscoveryBackend) SetCommsClient(agentID string, client *mqtt.Client, baseTopic string) {
+func (d *networkDiscoveryBackend) SetCommsClient(_ string, client *mqtt.Client, _ string) {
 	d.mqttClient = client
-	otelBaseTopic := strings.Replace(baseTopic, "?", "otlp", 1)
-	d.otlpMetricsTopic = fmt.Sprintf("%s/m/%c", otelBaseTopic, agentID[0])
 }
 
 func (d *networkDiscoveryBackend) Version() (string, error) {