Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(classic): Dispatch global actions with undefined cursor to occur on a viable parent level #148

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

filipboev
Copy link
Contributor

We briefly discussed this with @ognen.

We only want to do this for global actions that are being dispatched. There are some cases where the result of .query(path) returns undefined due to no cursor being present at that path anymore. This causes the dispatch to fizzle out because actions.atCursor will fail at this line, when trying to access _keyPath from undefined.

Anyway, I opened this PR in order to discuss this first and see if we can tackle this problem another way.

@coveralls
Copy link

coveralls commented Nov 11, 2019

Pull Request Test Coverage Report for Build 462

  • 3 of 12 (25.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 80.727%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/classic/src/kernel.js 3 12 25.0%
Totals Coverage Status
Change from base Build 459: -0.6%
Covered Lines: 1209
Relevant Lines: 1431

💛 - Coveralls

packages/classic/src/kernel.js Outdated Show resolved Hide resolved
packages/classic/src/kernel.js Outdated Show resolved Hide resolved
packages/classic/src/kernel.js Outdated Show resolved Hide resolved
packages/classic/src/kernel.js Outdated Show resolved Hide resolved
packages/classic/src/kernel.js Outdated Show resolved Hide resolved
@filipboev filipboev requested a review from ognen November 12, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants