Skip to content

Commit

Permalink
used request uid as random uid to create name
Browse files Browse the repository at this point in the history
  • Loading branch information
dariuszSki committed Sep 27, 2024
1 parent 9a9d285 commit 30191e3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 9 deletions.
12 changes: 4 additions & 8 deletions ziti-agent/cmd/webhook/pods.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ import (
k "github.com/netfoundry/ziti-k8s-agent/ziti-agent/kubernetes"
ze "github.com/netfoundry/ziti-k8s-agent/ziti-agent/ziti-edge"

"github.com/google/uuid"
"github.com/openziti/edge-api/rest_management_api_client"
"github.com/openziti/sdk-golang/ziti"
admissionv1 "k8s.io/api/admission/v1"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/klog/v2"
)

Expand Down Expand Up @@ -71,7 +71,7 @@ func zitiTunnel(ar admissionv1.AdmissionReview) *admissionv1.AdmissionResponse {
return failureResponse(reviewResponse, err)
}

identityCfg, sidecarIdentityName, err := createAndEnrollIdentity(pod.Labels["app"], roles, zec)
identityCfg, sidecarIdentityName, err := createAndEnrollIdentity(pod.Labels["app"], ar.Request.UID, roles, zec)
if identityCfg == nil {
return failureResponse(reviewResponse, err)
}
Expand Down Expand Up @@ -337,13 +337,9 @@ func hasContainer(containers []corev1.Container, containerName string) (string,
return "", false
}

func createSidecarIdentityName(appName string) string {
id, _ := uuid.NewV7()
return fmt.Sprintf("%s-%s%s", trimString(appName), sidecarPrefix, id)
}
func createAndEnrollIdentity(name string, uid types.UID, roles []string, zec *rest_management_api_client.ZitiEdgeManagement) (*ziti.Config, string, error) {

func createAndEnrollIdentity(name string, roles []string, zec *rest_management_api_client.ZitiEdgeManagement) (*ziti.Config, string, error) {
identityName := createSidecarIdentityName(name)
identityName := fmt.Sprintf("%s-%s%s", trimString(name), sidecarPrefix, uid)

identityDetails, err := ze.CreateIdentity(identityName, roles, "Device", zec)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion ziti-agent/cmd/webhook/webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func serve(w http.ResponseWriter, r *http.Request, admit admitHandler) {
responseAdmissionReview.Response.UID = requestedAdmissionReview.Request.UID
responseObj = responseAdmissionReview

klog.Infof(fmt.Sprintf("Admission Response v1: %s", responseObj))
klog.Infof(fmt.Sprintf("Admission Response UID: %s", responseAdmissionReview.Response.UID))

case admissionv1.SchemeGroupVersion.WithKind("AdmissionReview"):
requestedAdmissionReview, ok := obj.(*admissionv1.AdmissionReview)
Expand Down

0 comments on commit 30191e3

Please sign in to comment.