Project no longer uses clone3() #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clone3() has been depecrated, this commit removes it and replaces it, so now the project can run in newer P4c versions. Now makefile uses new docker syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clone3() has been deprecated, this commit removes it and replaces it, so now the project can run in newer P4c versions. Now makefile uses new docker syntax.
Also fixed a problem that made the Routing Tables Setup Fail, more details can be seen here: #2 (comment)
At the end of define.p4, there are duplicated values that can be deleted and the use of those variables can also be easily replaced by values that are already defined on that file.